[Workspaces] Fix snapshotting minimized apps #37598
Open
+34
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeraphimaZykova
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- src/modules/Workspaces/WorkspacesSnapshotTool/SnapshotUtils.cpp: Language not supported
- src/modules/Workspaces/WorkspacesWindowArranger/WindowArranger.cpp: Language not supported
- src/modules/Workspaces/workspaces-common/WindowFilter.h: Language not supported
vanzue
approved these changes
Feb 25, 2025
|
Works in my testing environment, approve |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Some minimized packaged apps (Microsoft ToDo, Settings) were not snapshotted. This PR fixes the issue
PR Checklist
Detailed Description of the Pull Request / Additional comments
Fixing filter used when enumerating through all the windows. With the fix, the minimized packaged apps are not filtered out.
Validation Steps Performed
tested locally